Game-rule (plausibility) checks for reported and Reddit comment runs #22

Closed
opened 2026-11-19 03:29:19 +00:00 by kathleen · 0 comments
Owner

The community form's rows get game-rule checks in core/atlas/coding.py, which set data_flags:

  • sighting pool;
  • an encounter that doesn't match the dragon's colour;
  • a Green in the valley;
  • a death in combat without a fight;
  • and so on.

Rows from reported (the "Report a run" form) and reddit comment (Ken's scraper, #18) go through answers_row() and get none of these. In Ken's first real scrape, 10 of 82 runs broke a rule.

To do

  • Run the same checks on every row coded from answers. Ideally one function shared by the spreadsheet coder and answers_row(), so the rules can't drift apart.
  • Use the same flag texts, so the "impossible / doubtful" list from the issue above applies to every source.
  • Tests: one row per rule, for each source.

Blocks: "Use every possible run…"

The community form's rows get game-rule checks in `core/atlas/coding.py`, which set `data_flags`: - sighting pool; - an encounter that doesn't match the dragon's colour; - a Green in the valley; - a death in combat without a fight; - and so on. Rows from `reported` (the "Report a run" form) and `reddit comment` (Ken's scraper, #18) go through `answers_row()` and get none of these. In Ken's first real scrape, **10 of 82** runs broke a rule. ## To do - Run the same checks on every row coded from answers. Ideally one function shared by the spreadsheet coder and `answers_row()`, so the rules can't drift apart. - Use the same flag texts, so the "impossible / doubtful" list from the issue above applies to every source. - Tests: one row per rule, for each source. Blocks: "Use every possible run…"
kathleen added the redditdata quality labels 2026-11-19 03:29:19 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DragonKind/threshing-atlas#22