Code the sheet's new answers; report failed builds as issues #8

Merged
kathleen merged 2 commits from fix/new-sheet-answers-1117 into main 2026-11-17 23:49:04 +00:00
Owner

The source check I started this evening (run #30) stopped at validation, which is the intended behaviour, on two answers the coding rules didn't know yet:

  • First sighting "2 Greens": a new option on the form. It's coded as Green, and the row gets a data flag (first sighting answered as '2 Greens') so the original answer is kept. The mapping lives in core/spec/form.yaml (first_sighting_alias).
  • Row label "Unknown" on a bulk-pasted row: added to the entry values in data/dictionary.yaml.

Workflow fixes. When validation fails, the rebuild step used to run anyway and crash, so the "Source check failed" issue was never opened. Now, when collection update reports a failed build:

  • the rebuild is skipped;
  • no data pull request is opened;
  • the issue always opens, listing the new answers.

🤖 Generated with Claude Code

The source check I started this evening (run #30) stopped at validation, which is the intended behaviour, on two answers the coding rules didn't know yet: - **First sighting "2 Greens"**: a new option on the form. It's coded as `Green`, and the row gets a data flag (`first sighting answered as '2 Greens'`) so the original answer is kept. The mapping lives in `core/spec/form.yaml` (`first_sighting_alias`). - **Row label "Unknown"** on a bulk-pasted row: added to the `entry` values in `data/dictionary.yaml`. **Workflow fixes.** When validation fails, the rebuild step used to run anyway and crash, so the "Source check failed" issue was never opened. Now, when `collection update` reports a failed build: - the rebuild is skipped; - no data pull request is opened; - the issue always opens, listing the new answers. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
kathleen added 2 commits 2026-11-17 23:48:59 +00:00
The evening source check stopped (correctly) on two answers the coding rules did not know:
- first sighting "2 Greens": a new form option. Coded as Green, with a data flag that keeps the
  original answer (first_sighting_alias in core/spec/form.yaml).
- row label "Unknown" on a bulk-pasted row: added to the entry values in data/dictionary.yaml.

Workflow: when `collection update` reports the build failed, skip the rebuild (it would only fail
again) and always open the "Source check failed" issue, so new answers are reported, not lost.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UCzTd31GphpMXDhQqWrCMQ
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UCzTd31GphpMXDhQqWrCMQ
kathleen scheduled this pull request to auto merge when all checks succeed 2026-11-17 23:49:03 +00:00
kathleen merged commit 9af9762314 into main 2026-11-17 23:49:04 +00:00
kathleen deleted branch fix/new-sheet-answers-1117 2026-11-17 23:49:04 +00:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DragonKind/threshing-atlas#8